Ergodox: Make LEDs indicate the layer you are on

Comments

5 responses to “Ergodox: Make LEDs indicate the layer you are on”

1. 

   anro

   June 4, 2014

   There’s a slight bug here.
   To turn off a LED you should use:
   keyboard_leds &= (uint8_t) ~(0x01);

   This works because it makes a mask of 1s of all bits *except* the bit representing the LED you want to turn off, thereby leaving other LEDs in whatever state they were in previously.

   Your example above actually does the opposite of what you want:
   keyboard_leds &= (0x01)
   will turn off all LEDs except that one when you exit the layer. This is because the mask has all zeroes except for the selected LED and the AND operation will only preserve the LED that you want, in this case, to turn off.

   Your use of binary OR is the correct way to turn on a LED when entering a layer without affecting the status of other LEDs.

   I found this post quite helpful in my own hacking on my ergodox. Thanks!

2. 

   Moazzam

   June 8, 2014

   Thanks for pointing that out anro. I will confirm it and change my post accordingly. And, I am very glad you found it helpful.

3. 

   Duq

   June 14, 2014

   Hello!

   Upon constructing my ergodox and using it for a bit I found that it would be useful to have a layer indicator because how I appropriated my layers.

   https://www.massdrop.com/ext/ergodox/?referer=ZXKRQ7&hash=b209b02042f5ab4d3b372634dcbdd187

   I play random for SC2 and there were some keys that were particularly terrible to get to because of the split configuration. I haven’t hashed through everything yet, but the main ones were these:

   zerg: ‘h’ for hatcheries
   protoss: ‘y’ for cybernetics core
   terran: ‘u’ for bunker and ‘l’ for lift

   I still have more discovery to do, but it already made it apparent that I would have to do this if I were to make a right attempt at making the ergodox work on the regular.

   Anyway, I have a layer for each race[layer 1, layer 2, layer 3] and brought over the offending keys to the 1.5 unit keys on the left hand.

   Now, the meat of this post… how to enable the LED indicators existing(LEDa, LEDb, and LEDc) to indicate what layer you are on.

   I used your code to base how I did it:
   http://moazzam-khan.com/blog/?p=885

   It did not work for me… It did turn the LEDs on for me but it would not turn them off…

   Your current construct for turning off the LEDs is(placed in the ‘pop’ function of the desired layer):
   keyboard_leds = keyboard_leds & 0x01;

   The following does not work either:
   keyboard_leds = keyboard_leds & 0x01;

   There is comment to use:
   keyboard_leds &= (uint8_t) ~(0×01); or keyboard_leds &= (0×01)

   Does not work either.

   What I found that works is this line:
   keyboard_leds = 0x00;

   The final source should look similar to this:
   Code: [Select]
   void kbfun_layer_push_1(void) {
   keyboard_leds = keyboard_leds | 0x01;
   layer_push(1);
   }

   /*
   * [name]
   * Layer pop #1
   *
   * [description]
   * Pop the layer element created by the corresponding “layer push” function
   * out of the layer stack (no matter where it is in the stack, without
   * touching any other elements)
   */
   void kbfun_layer_pop_1(void) {
   keyboard_leds = 0x00;
   layer_pop(1);
   }

   AND, if you pay attention to how I did my layers you should always have an appropriate pop button to go back to the base layer to clear the LED and bring you back to the base layer.

   Hope this helps someone, because it took a bit of tinkering. Big thanks to Moazzam for getting me started.

   Regards,
   Duq

4. 

   Moazzam

   June 16, 2014

   I updated the post with the right way to turn LEDs off (at least with what worked for me)

5. 

   patrain

   September 9, 2014

   This is great man. I got it to work great for Layer 1 being the caps lock led and Layer 2 as the scroll lock led. Only issue is that caps lock turns the light on and off independently of the layer pushing and popping. Ill look into that later, just some thing to fix I guess.